Added height to close button

[mtruj013]

Done

• Added min height to .p-notification__close to fix positioning issue when missing button text

• Fixes Notification dismiss button height depends on invisible text #4034

QA

• Open demo
• Go to patterns > notification > actions > buttons
• Edit on codepen or checkout current branch
• Remove close button text and ensure positioning is unchanged

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

• PR should have one of the following labels to automatically categorise it in release notes:
  • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
• Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
  • if CSS class names are not changed it can be bugfix relesase (x.x.X)
  • if CSS class names are changed/added/removed it should be minor version (x.X.0)
  • see the wiki for more details
• Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
• Documentation side navigation should be updated with the relevant labels.

[webteam-app]

Demo starting at https://vanilla-framework-4267.demos.haus

[bethcollins92]

LGTM code wise. Just want to double check something with @lyubomir-popov

Although the calculation makes sense (2 x padding + icon size), the x icon is alignment is very slightly different on live. See screen shots below.

Live:

Demo:

[lyubomir-popov]

@bethcollins92 @mtruj013 it's not a problem, the icon buttons aren't perfectly square, hence the small difference.
Making the button square as you've done here is an improvement.

[bethcollins92]

LGTM - yay