Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty state - 1st variant #4274

Merged
merged 15 commits into from
Feb 1, 2022
Merged

Conversation

ilayda21
Copy link
Contributor

@ilayda21 ilayda21 commented Jan 25, 2022

Done

  • Variant 1 empty state is added.
  • Empty state is added to docs.

Fixes #1010

QA

  • Open empty state example
  • Verify its implemented according to design
  • Open docs
  • Verify empty state's no content variant is documented correctly.
  • Open whats new section.
  • Verify "empty state" is added.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@ilayda21 ilayda21 added the Feature 馃巵 New feature or request label Jan 25, 2022
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4274.demos.haus

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples look great! I've spoken to Scott and we both aren't sure of the placement in the base section. I'm sure Bartek has a reason for this but we will wait until he's back to check his reasoning. Nice work :)

templates/docs/base/empty-state.md Outdated Show resolved Hide resolved
templates/docs/whats-new.md Outdated Show resolved Hide resolved
@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Jan 27, 2022

Hi, 2 comments from me:

  1. Could you please add u-no-margin--bottom to all h4 headings, and change the small text to regular paragraphs please?
    Should look like this:

Before:
image

After:
image

  1. The documentation page shows one left-aligned example (as per the brief and benchmarking, and consistent with everything else we do), and 2 central alignment examples (not consistent with anything else we do, but strongly favoured in the original design).

Unless there's a section of the documentation explaining when to use which, I'd suggest dropping the central alignment examples. cc @spencerbygraves

@spencerbygraves
Copy link

I'd agree it seems unnecessary to have the centred version.

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! - as we discussed if you could move the example into the layout section, and I'll double check with @bartaz on Monday this is an appropriate place for it. Thanks!

@bethcollins92
Copy link
Contributor

@lyubomir-popov could you take another look please and design +1 if you're happy

@bethcollins92
Copy link
Contributor

LGTM but let's wait for Bartek to check it's ok in the layout section

@bartaz
Copy link
Contributor

bartaz commented Feb 1, 2022

Thanks for implementing this. I tried to clean up this PR from unnecessary duplicated commits from main branch, hopefully I didn't mess up something.

As for the placement of the Empty State page - we don't seem to have a good place for it at the moment. "Empty state" is a design pattern, built out of Vanilla components. It's definitely not a layout, it's also not a base element, and technically not a component (but probably closest to be one). So I guess for now we either put it in "Components" or create a new section "Patterns" for it (but this means we only have Empty State there for a while).

@bartaz bartaz force-pushed the ilayda-empty-state-v1 branch 2 times, most recently from 7b3f360 to 5fb1b71 Compare February 1, 2022 14:00
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the empty state page to components section.

LGTM now, thanks!

@bartaz bartaz merged commit fc750b7 into canonical:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants