-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empty state - 1st variant #4274
Conversation
Demo starting at https://vanilla-framework-4274.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples look great! I've spoken to Scott and we both aren't sure of the placement in the base section. I'm sure Bartek has a reason for this but we will wait until he's back to check his reasoning. Nice work :)
templates/docs/examples/base/empty-state/no-content-page-view.html
Outdated
Show resolved
Hide resolved
Hi, 2 comments from me:
Unless there's a section of the documentation explaining when to use which, I'd suggest dropping the central alignment examples. cc @spencerbygraves |
I'd agree it seems unnecessary to have the centred version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! - as we discussed if you could move the example into the layout section, and I'll double check with @bartaz on Monday this is an appropriate place for it. Thanks!
@lyubomir-popov could you take another look please and design +1 if you're happy |
5fd9df0
to
8826812
Compare
LGTM but let's wait for Bartek to check it's ok in the layout section |
Co-authored-by: Beth Collins <beth.collins@canonical.com>
Co-authored-by: Beth Collins <beth.collins@canonical.com>
73af0bb
to
43b87c3
Compare
Thanks for implementing this. I tried to clean up this PR from unnecessary duplicated commits from As for the placement of the Empty State page - we don't seem to have a good place for it at the moment. "Empty state" is a design pattern, built out of Vanilla components. It's definitely not a layout, it's also not a base element, and technically not a component (but probably closest to be one). So I guess for now we either put it in "Components" or create a new section "Patterns" for it (but this means we only have Empty State there for a while). |
7b3f360
to
5fb1b71
Compare
5fb1b71
to
d253313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the empty state page to components section.
LGTM now, thanks!
Done
Fixes #1010
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: