-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empty state - Variant 3 #4279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4279.demos.haus |
ilayda21
force-pushed
the
ilayda-empty-state-v3
branch
from
January 26, 2022 09:17
771dc00
to
21cd1fe
Compare
ilayda21
force-pushed
the
ilayda-empty-state-v3
branch
from
January 27, 2022 11:47
21cd1fe
to
d8aa322
Compare
ilayda21
force-pushed
the
ilayda-empty-state-v3
branch
2 times, most recently
from
January 28, 2022 12:54
c4a1f11
to
1d40a8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great Ilayda! Just a few comments to address in the code
templates/docs/examples/layouts/empty-state/error-management.html
Outdated
Show resolved
Hide resolved
templates/docs/examples/layouts/empty-state/error-management.html
Outdated
Show resolved
Hide resolved
templates/docs/examples/layouts/empty-state/user-triggered.html
Outdated
Show resolved
Hide resolved
templates/docs/examples/layouts/empty-state/error-management.html
Outdated
Show resolved
Hide resolved
bethcollins92
added
Review: Code -1
Review: QA +1
and removed
Review: QA needed
Review: Code needed
labels
Jan 28, 2022
bartaz
force-pushed
the
ilayda-empty-state-v3
branch
from
February 2, 2022 07:41
bed25dc
to
7b32e57
Compare
Co-authored-by: ilayda21 <ilayda.cavusoglu@canonical.com>
bartaz
force-pushed
the
ilayda-empty-state-v3
branch
from
February 2, 2022 07:58
7b32e57
to
9f8f43f
Compare
bartaz
added
Review: Code needed
Review: QA needed
and removed
Review: QA +1
Review: Code -1
labels
Feb 2, 2022
bethcollins92
added
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
Feb 2, 2022
bethcollins92
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after #4276
Done
Fixes #1010
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: