Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added notification accessibility docs #4288

Merged
merged 8 commits into from
Jan 31, 2022

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 28, 2022

Done

QA

  • Open demo
  • Check that each dismissible notification has the aria-controls attribute on the close button
  • QA the accessibility and considerations section of the notification docs

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4288.demos.haus

@mtruj013 mtruj013 added Documentation 馃摑 Documentation changes or updates Review: QA needed labels Jan 28, 2022
Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks @mtruj013. One small comment but then good to merge

templates/docs/patterns/notification.md Outdated Show resolved Hide resolved
@bethcollins92 bethcollins92 merged commit 8363ea1 into canonical:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 馃摑 Documentation changes or updates Review: QA +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accessibility Docs] Notifications
3 participants