Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace <cite> with <span> pull-quotes #4300

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Feb 7, 2022

Done

  • Replace <cite> with <span> pull-quotes. Semantically, cites should only be used to refer to someone's work, not their name

Fixes #4263

QA

  • Open demo
  • Check there are no visual changes in the pull quote examples
  • Check VoiceOver works as expected

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4300.demos.haus

@bethcollins92
Copy link
Contributor Author

@bartaz Sounds good - done

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit 4147068 into canonical:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<cite> shouldn't be included inside <blockquote> in pull quote
3 participants