Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock MarkupSafe at version 2.0.1 #4325

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Feb 18, 2022

Done

Fixes issues caused by breaking change in MarkupSafe affecting Jinja: pallets/jinja#1587

QA

  • All CI checks should pass

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4325.demos.haus

@bartaz bartaz merged commit 7e9ecc9 into canonical:main Feb 18, 2022
@davidism
Copy link

It looks like you are not pinning your dependencies. Use something like pip-tools to pin dependencies so you control when updates happen.

@bartaz bartaz deleted the markupsafe-fix branch May 27, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants