Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sections to Notification docs #4333

Merged
merged 5 commits into from
Feb 23, 2022

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Feb 22, 2022

Done

  • added JS functionality docs to Notifications
  • added related components to Notifications docs
  • added class reference to Notifications docs

Fixes canonical-web-and-design/vanilla-squad#1197

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.

@bartaz bartaz added Review: QA needed Documentation 馃摑 Documentation changes or updates labels Feb 22, 2022
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4333.demos.haus

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of changes. Not really a blocker but the Javascript section looks a bit close to the table

Screenshot 2022-02-22 at 16 45 52

templates/docs/patterns/notification.md Outdated Show resolved Hide resolved
templates/docs/patterns/notification.md Outdated Show resolved Hide resolved
bartaz and others added 2 commits February 23, 2022 10:00
Co-authored-by: Beth Collins <beth.collins@canonical.com>
@bartaz bartaz merged commit 6fb830a into canonical:main Feb 23, 2022
@bartaz bartaz deleted the notification-js-docs branch May 27, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 馃摑 Documentation changes or updates Review: QA +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants