Read class reference data from SCSS files #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4349.demos.haus |
bartaz
force-pushed
the
classreference-hackday
branch
from
7e505fe
to
56073b1
Compare
bartaz
commented
Apr 28, 2022
bartaz
added
Documentation 📝
bartaz
changed the title
There was a problem hiding this comment.
LGTM with a couple of minor comments (I've asked @albertkol to review the python 😀)
| @@ -86,7 +86,7 @@ View example of the time notification pattern | |||
|
|
|||
| ## Class reference | |||
|
|
|||
| {% include "_class-references/notification.html" %} | |||
| {{ class_reference() }} | |||
There was a problem hiding this comment.
Why is this one missing "notification" in the brackets?
There was a problem hiding this comment.
Doesn't need it. The function is smart enough to match it from the page it is on (via URL), only needs it when URL slug doesn't match the component name 1:1.
Co-authored-by: Beth Collins <bethcollinsliv92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Based on work from the hackaton, we are reading Yaml data for class reference from the comments inside SCSS files.
QA
dotrun build-class-references