-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close contextual menu when focus leaves #4359
Close contextual menu when focus leaves #4359
Conversation
Demo starting at https://vanilla-framework-4359.demos.haus |
db0b533
to
d6a28b8
Compare
|
||
setupAllContextualMenus('.p-contextual-menu'); | ||
setupAllContextualMenus('.p-contextual-menu--left'); | ||
setupAllContextualMenus('.p-contextual-menu--center'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can do it in one call, separating selectors setupAllContextualMenus('.p-contextual-menu, .p-contextual-menu--left, .p-contextual menu--center')
.
But also, to avoid listing all the variants you could do:
setupAllContextualMenus('.p-contextual-menu, [class*="p-contextual-menu--"]')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with little suggestion to consider
Done
Fixes #4284
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: