Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aria-labels on landmarks #4361

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Mar 10, 2022

Done

  • Removed the word "navigation" from all aria-label's on <nav> elements, to fix duplication with screen readers.
  • Checked all <header> and <main> tags too

Fixes #4133

QA

  • Open demo
  • Use VoiceOver on the navigation landmarks such as pagination or side navigation to check duplication has been removed
  • Check out this PR, in VsCode search for navigation" and there should be no more instances of the word navigation in nav elements

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4361.demos.haus

@bethcollins92
Copy link
Contributor Author

@bartaz This PR got lost in the abyss! It wasn't in the review column wupsy. Anyway it looks like a lot of file changes but it's just updating aria-labels etc to avoid duplication on AT. Just tagging you incase you have time to review it on Monday when I'm not here

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A11Y: Review and fix landmarks on Vanilla site and docs
3 participants