Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken snippet__line outside of snippet_block--numbered #4363

Conversation

ClementChaumel
Copy link
Contributor

@ClementChaumel ClementChaumel commented Mar 15, 2022

Done

Fix snippet__line displaying incorrectly when used outside of snippet_block--numbered

Fixes #4357

QA

  • Open demo
  • It should display correctly
  • inspect the page and take --numbered out of the parent element's class
  • it shouldn't display any numbers

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Current behaviour:
image

After this is merged:
image

@webteam-app
Copy link

webteam-app commented Mar 15, 2022

Copy link
Contributor

@bethcollins92 bethcollins92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! First Vanilla PR in the bag 馃コ

@ClementChaumel ClementChaumel merged commit bf7dfc1 into canonical:main Mar 16, 2022
@ClementChaumel ClementChaumel deleted the 4357-Numbered-lines-appear-outside-numbered-code-snippet-block branch March 16, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Numbered lines appear outside numbered code snippet block
3 participants