Rename "p-label" to "p-status-label" #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4400.demos.haus |
andesol
added
Feature 馃巵
andesol
changed the title
p-label to p-status-label
bartaz
reviewed
Apr 12, 2022
bartaz
reviewed
Apr 12, 2022
| @@ -74,7 +74,6 @@ | |||
| {{ side_nav_item("/docs/patterns/heading-icon", "Heading icon") }} | |||
| {{ side_nav_item("/docs/patterns/icons", "Icons") }} | |||
| {{ side_nav_item("/docs/patterns/images", "Images") }} | |||
| {{ side_nav_item("/docs/patterns/labels", "Labels") }} | |||
There was a problem hiding this comment.
We remove this page, so the contents (labels.md) file should be removed as well.
There was a problem hiding this comment.
I simply renamed the file (https://github.com/canonical-web-and-design/vanilla-framework/pull/4400/files#diff-b5623168757e725faf8450740b0d9cdf3fe879d342b8f72c8f5dd0ac4619f674), so I think labels.md it's already deleted
bartaz
reviewed
Apr 12, 2022
|
Couple small things to make the docs complete and ready for release:
|
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
|
I think this is ready for a review! |
bethcollins92
approved these changes
Apr 12, 2022
bethcollins92
added
Review: Code +1 (with changes)
and removed
Review: Code needed
labels
Co-authored-by: Beth Collins <beth.collins@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
p-status-labeland add it to the examples section(I'm happy to use the deprecate mixin but I couldn't find an example)
Fixes #4395
QA
/docs/examplesand check there are both a "label" and a "status label" components (and both work)Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention: