Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Tab buttons from tabs #4401

Merged

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Apr 11, 2022

Done

  • Separate Tab buttons from tabs
  • I didn't include the accessibility docs for now as we might need to take a look at the spec for segmental control and check what applies
  • NOTE: Renaming will be done in a separate PR

Fixes #1310

QA

  • Open demo
  • Check the content in the tab buttons docs page makes sense

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4401.demos.haus

@bethcollins92 bethcollins92 force-pushed the 1310-build-segmented-button-page branch from 7e42b03 to 1969337 Compare April 12, 2022 14:21
Copy link
Contributor

@andesol andesol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bethcollins92 bethcollins92 merged commit 358f4d8 into canonical:main Apr 13, 2022
@bethcollins92 bethcollins92 deleted the 1310-build-segmented-button-page branch April 13, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants