Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accordion #4406

Merged
merged 6 commits into from
Apr 20, 2022
Merged

Update accordion #4406

merged 6 commits into from
Apr 20, 2022

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 12, 2022

Done

Fixes #4397

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4406.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Apr 12, 2022

Something happened to the borders between accordion items, they are not visible until accordion is open (?).
It seems to be related to position: relative added to the button, but I haven't figured out yet how to get around that:

accordion

@bartaz
Copy link
Contributor

bartaz commented Apr 19, 2022

@andesol I guess we should bump the version to 3.2.1 in this one. And while it is not a new "feature" from CSS point of view, the design change is quite important and visible, so would be good to add Accordion as "Updated" in side nav and in "what's new page".

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lyubomir-popov
Copy link
Contributor

LGTM

@andesol andesol merged commit 70e4dc9 into canonical:main Apr 20, 2022
@andesol andesol deleted the accordion branch April 20, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion update - build
4 participants