-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update accordion #4406
Update accordion #4406
Conversation
Demo starting at https://vanilla-framework-4406.demos.haus |
8c8a87c
to
5433989
Compare
@andesol I guess we should bump the version to 3.2.1 in this one. And while it is not a new "feature" from CSS point of view, the design change is quite important and visible, so would be good to add Accordion as "Updated" in side nav and in "what's new page". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Done
Fixes #4397
QA
e.g. https://vanilla-framework-4406.demos.haus/docs/examples/patterns/accordion/default
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention: