Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "tab buttons" to "segmented control" #4410

Merged
merged 9 commits into from
Apr 19, 2022

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 13, 2022

Done

  • Rename scss files from "tab-buttons" to "segmented-control" (but keep the old classes for compatibility)
  • Update documentation
  • Add example for the "new" component

Fixes https://github.com/canonical-web-and-design/vanilla-squad/issues/1328

QA

  • Open demo
  • In the examples section, check that both "tab buttons" and "segmented control" work in its different variants.
  • Review updated documentation:
    • Segmented control

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4410.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Apr 14, 2022

We probably mention vf-p-tab-buttons somewhere in the docs (at least in the import section) so we should update that.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added couple comments inline in the code.

templates/docs/whats-new.md Outdated Show resolved Hide resolved
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit 2c50ff7 into canonical:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants