Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate label pattern #4416

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Deprecate label pattern #4416

merged 4 commits into from
Apr 21, 2022

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 19, 2022 •
edited

Done

  • Bring vf-p-label mixin back due to compatibility reasons
  • Flag the label component as deprecated in the examples section
  • Add a notification in the migration to 3.0 guide
  • Rename p-label to p-status-label in the markup

Fixes #4411

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4416.demos.haus

@bethcollins92 bethcollins92 self-assigned this Apr 20, 2022
bartaz
bartaz reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit 0f574e8 into canonical:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees

@bethcollins92 bethcollins92

Labels
Maintenance 🔨 Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properly deprecate vf-p-label
4 participants
@andesol @webteam-app @bartaz @bethcollins92