Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add menu to all patterns #4427

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Add menu to all patterns #4427

merged 3 commits into from
Apr 20, 2022

Conversation

albertkol
Copy link
Contributor

@albertkol albertkol commented Apr 20, 2022 •
edited

Done

Add tabs to all other patterns that had accessibility sections:

  • patterns/breadcrumbs
  • patterns/buttons
  • patterns/card
  • patterns/contextual-menu
  • patterns/grid
  • patterns/heading-icon
  • patterns/icon
  • patterns/links
  • patterns/lists
  • patterns/logo-section
  • patterns/modal
  • patterns/navigation
  • patterns/notification
  • patterns/pagination
  • patterns/search-box
  • patterns/status-labels
  • patterns/strip
  • patterns/switch
  • patterns/tabs
  • patterns/tooltips

QA

  • Check all other patterns with accessibility pages, they should have the menu and work just as well as accordion did on the previous PR.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4427.demos.haus

@albertkol albertkol changed the base branch from main to new-vanilla-website April 20, 2022 09:12
bartaz
bartaz reviewed Apr 20, 2022
View reviewed changes
component_tabs.yaml Outdated Show resolved Hide resolved
bartaz
bartaz approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a little change to consider

@albertkol albertkol merged commit da9b27f into canonical:new-vanilla-website Apr 20, 2022
@albertkol albertkol deleted the add-menu-to-all-patterns branch April 20, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 (with changes) Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@albertkol @webteam-app @bartaz