Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version in package.json #4431

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Fix version in package.json #4431

merged 1 commit into from
Apr 21, 2022

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Apr 20, 2022

Done

Fixes the version number in package.json
Seems we unnecessarily bumped to 3.3.1 without releasing 3.3.0.

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4431.demos.haus

@bartaz bartaz merged commit 7bea929 into main Apr 21, 2022
@bartaz bartaz deleted the bartaz-patch-1 branch April 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants