Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix page jumping after codepen loads #4432

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Fix page jumping after codepen loads #4432

merged 2 commits into from
Apr 22, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented Apr 20, 2022 •
edited

Done

  • Add a fix scroll function to ensure the codepen loading doesn't move the title out of view

Fixes #3017

QA

  • Open demo
  • Check that the "Side navigation" title is in view.
  • Compare to main

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4432.demos.haus

@bethcollins92 bethcollins92 force-pushed the 3017-loading-page-moves branch 2 times, most recently from a4ac4e4 to 1de0c6c Compare April 21, 2022 07:49
@bethcollins92 bethcollins92 force-pushed the 3017-loading-page-moves branch 2 times, most recently from a7962de to b3dda17 Compare April 21, 2022 15:27
@bethcollins92 bethcollins92 changed the title WIP fix scroll on docs Fix page jumping after codepen loads Apr 21, 2022
@bethcollins92 bethcollins92 marked this pull request as ready for review April 21, 2022 15:31
andesol
andesol approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@andesol andesol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such an elegant solution 馃挴

Just a minor detail...

templates/static/js/example.js Outdated Show resolved Hide resolved
@bethcollins92 bethcollins92 merged commit 3faa6a3 into canonical:main Apr 22, 2022
@bethcollins92 bethcollins92 deleted the 3017-loading-page-moves branch April 22, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz left review comments

@andesol andesol andesol approved these changes

Assignees
No one assigned
Labels
Bug 馃悰 Review: Code +1 (with changes) Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading of embedded examples moves the page when loading specific section
4 participants
@bethcollins92 @webteam-app @bartaz @andesol