Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update accordion docs #4436

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Update accordion docs #4436

merged 1 commit into from
Apr 21, 2022

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 21, 2022 •
edited

Done

Very little change: added some headings to make the structure of the accordion docs easier to follow and consistent with other patterns (e.g. card)

QA

  • Open demo
  • Go to the accordion page and check if the change makes sense

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4436.demos.haus

bartaz
bartaz approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit e116a4f into canonical:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andesol @webteam-app @bartaz