Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to keep tooltip open on click #4454

Merged
merged 1 commit into from
May 6, 2022

Conversation

bethcollins92
Copy link
Contributor

@bethcollins92 bethcollins92 commented May 5, 2022

Done

  • Ensured the detached tooltip stays open on click of the trigger, and closes when escape is pressed or the user clicks outside or on the trigger

Fixes #4412

QA

  • Open demo
  • Hover/focus over the detached tooltip and check the functionality is still the same
  • Click on the tooltip and move the mouse away. The tooltip should remain open
  • Now press escape and check the tooltip closes
  • Do the same again but click outside instead of pressing escape - the tooltip should close.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4454.demos.haus

@bethcollins92 bethcollins92 merged commit 5536846 into canonical:main May 6, 2022
@bethcollins92 bethcollins92 deleted the 4412-detached-tooltip branch May 6, 2022 11:24
@bartaz bartaz added Documentation 馃摑 Documentation changes or updates and removed Maintenance 馃敤 labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detached Tooltip on click should remain open until dismissed
3 participants