Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix contribute page #4462

Merged
merged 2 commits into from
May 17, 2022
Merged

Fix contribute page #4462

merged 2 commits into from
May 17, 2022

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented May 17, 2022 •
edited

Done

  • Fixes links to practice website
  • Removes Beth from the team 馃槶

Fixes #4449

QA

  • Open demo
  • Make sure the links to Guidelines on HTML and CSS best practices work as expected
  • Make sure Beth is not in the team (but is listed as contributor) - nothing personal, Beth!

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.

@bartaz bartaz added the Documentation 馃摑 Documentation changes or updates label May 17, 2022
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4462.demos.haus

@steverydz steverydz self-assigned this May 17, 2022
steverydz
steverydz approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@bartaz bartaz merged commit 7e28d10 into canonical:main May 17, 2022
@bartaz bartaz deleted the fix-contribute-page branch May 27, 2022 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees

@steverydz steverydz

Labels
Documentation 馃摑 Documentation changes or updates Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links for code standards don't work
3 participants
@bartaz @webteam-app @steverydz