Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heading styles for side navigation #4487

Merged
merged 5 commits into from
Jun 8, 2022

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jun 8, 2022

Done

Adds new p-side-navigation__heading class (with a --linked variant) to be used in docs to provide headings for side navigation item groups.

Drive by: Fixes an issue with too small embedded examples for side nav components

Fixes #4485

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4487.demos.haus

@bartaz bartaz added the Feature 馃巵 New feature or request label Jun 8, 2022
@bartaz bartaz marked this pull request as ready for review June 8, 2022 14:12
Copy link
Contributor

@andesol andesol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded examples are quite useless for side navigation
3 participants