-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create badge component #4497
Create badge component #4497
Conversation
Co-authored-by: ilayda21 <ilayda21@users.noreply.github.com>
…-design/vanilla-framework into create-badge-component
@ClementChaumel which design are you using for reference? These seem a bit different from the figma components https://www.figma.com/file/H6MSsN3taoXXOJCPUbIImQ/Design-System-Library?node-id=1310%3A9183 |
What are the font sizes, colours and spacing we should use? |
Udpated, PTAL @lyubomir-popov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of small comments in the code
scss/_patterns_tabs.scss
Outdated
@@ -46,7 +46,7 @@ | |||
border: none; | |||
color: $color-dark; | |||
display: flex; | |||
gap: $spv--medium; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no "medium" in horizontal spacing, use $sph--small
or $sph--large
in this case (I guess small should be enough?)
https://vanillaframework.io/docs/settings/spacing-settings#horizontal-spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe just use a n-space in a pseudo element? This shouldn't really be aligned with any spacing as it is a specific scenario between text and a rounded element, which we don't have in other places.
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small fix in accessibility docs, but LGTM. Thanks!
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Done
Create badge component and a few examples
Fixes #1394 #1395 #1396 #1397 #1398
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
Default:
Tabs:
Chips:
Colors:
Side Navigation: