Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated middot list style #4499

Merged
merged 3 commits into from
Jun 24, 2022
Merged

Updated middot list style #4499

merged 3 commits into from
Jun 24, 2022

Conversation

ilayda21
Copy link
Contributor

Done

  • Changed middot's position to relative
  • Updated the right margin of the middot list item

Fixes #4429

QA

  • Open demo
  • Reduce browser width to ~280px
  • Verify dots are displayed correctly

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4499.demos.haus

position: absolute;
right: -$sp-unit;
position: relative;
right: -(math.div($sp-unit, 2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution works great, thanks!
Where does the $sp-unit / 2 value come from? Does it need to be exactly that, or just an arbitrary value to keep the dot centered? If it's not necesarily related to sp-unit maybe it should be hardcoded?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just centers the dot horizontally. It can be hardcoded. I did it like that because $sp-unit is used there.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

package.json Outdated Show resolved Hide resolved
@bartaz bartaz merged commit d6f5f8b into canonical:main Jun 24, 2022
@ilayda21 ilayda21 deleted the middot-bug branch June 27, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Middots appear to wrap to the next line before their item does
3 participants