Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nesting and font weight when parent is a title #4501

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Jun 28, 2022

Done

Fixes font weight and indent of the items nested under the title items.

Fixes #4490

QA

  • Open demo
  • Make sure that when parent element is a bolded title, its children are not bolded and are properly indented

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4501.demos.haus

Copy link
Contributor

@ilayda21 ilayda21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side navigation items are bold and not indented if they are child of a title element
3 participants