Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badge accessibility #4503

Merged
merged 4 commits into from
Jul 1, 2022
Merged

Badge accessibility #4503

merged 4 commits into from
Jul 1, 2022

Conversation

ilayda21
Copy link
Contributor

@ilayda21 ilayda21 commented Jun 30, 2022

Done

  • Added items to badge's accessibility doc.
  • Added "aria-label" to the examples

Fixes https://github.com/canonical-web-and-design/vanilla-squad/issues/1405

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4503.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One unnecessary reference link to remove, but looks great, thanks!

@ilayda21 ilayda21 merged commit e115f4a into canonical:main Jul 1, 2022
@ilayda21 ilayda21 deleted the badge-accessibility branch July 1, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants