Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expandable side navigation #4536

Merged
merged 24 commits into from
Aug 24, 2022

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 17, 2022

Done

  • add expandable side navigation

Fixes https://github.com/canonical/vanilla-squad/issues/1420

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4536.demos.haus

@lyubomir-popov
Copy link
Contributor

LGTM 馃憤

scss/_patterns_side-navigation.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Aug 23, 2022

I think we should remove the "New" label and warning icon from this example.

We don't know if and how it would work with expand button, and we don't need to support that. Let's not give an impression that we do.
image

- add expandable dark docs variant
- add comment for hardcoded color
@bartaz bartaz merged commit ea44c39 into canonical:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants