-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expandable side navigation #4536
Merged
bartaz
merged 24 commits into
canonical:main
from
petermakowski:p-side-navigation-expand
Aug 24, 2022
Merged
feat: expandable side navigation #4536
bartaz
merged 24 commits into
canonical:main
from
petermakowski:p-side-navigation-expand
Aug 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4536.demos.haus |
petermakowski
force-pushed
the
p-side-navigation-expand
branch
4 times, most recently
from
August 17, 2022 14:26
0dbe9fa
to
99af210
Compare
4 tasks
petermakowski
force-pushed
the
p-side-navigation-expand
branch
from
August 18, 2022 10:36
99af210
to
401e8d1
Compare
LGTM 馃憤 |
bartaz
reviewed
Aug 18, 2022
templates/docs/examples/patterns/side-navigation/_expand_script.js
Outdated
Show resolved
Hide resolved
bartaz
reviewed
Aug 18, 2022
bartaz
reviewed
Aug 18, 2022
petermakowski
force-pushed
the
p-side-navigation-expand
branch
from
August 22, 2022 08:14
d68625a
to
6c40ca1
Compare
bartaz
reviewed
Aug 22, 2022
petermakowski
force-pushed
the
p-side-navigation-expand
branch
from
August 23, 2022 07:10
6c40ca1
to
dac12a2
Compare
bartaz
requested changes
Aug 23, 2022
- add expandable dark docs variant
- add comment for hardcoded color
bartaz
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes https://github.com/canonical/vanilla-squad/issues/1420
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]