Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accordion transition #4542

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 19, 2022

Done

  • add a transition to the accordion pattern

Fixes #4539

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

accordion-transition

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4542.demos.haus

@fitojb
Copy link
Contributor

fitojb commented Aug 19, 2022

Elegant and unique motion!

@bartaz
Copy link
Contributor

bartaz commented Aug 22, 2022

Could you bump package.json version to next patch (3.6.2) with this change?

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Aug 22, 2022

+1 on the animation, nice improvement. But I have an issue with the content - it implies this is a navigation, while being marked up with paragraphs. As such, the spacing between what looks like a nested accordion is inconsistent with the spacing in e.g. the side navigation. I think the content of the example should change to actual paragraph content to avoid confusion.

image

@lyubomir-popov
Copy link
Contributor

+1ed, we agreed to address the example content in a separate pr.

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@petermakowski petermakowski merged commit 2ae02c1 into canonical:main Aug 22, 2022
@petermakowski petermakowski deleted the feat-accordion-transition branch August 22, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accordion transition
5 participants