-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: accordion transition #4542
feat: accordion transition #4542
Conversation
Demo starting at https://vanilla-framework-4542.demos.haus |
01f33fd
to
c29e0be
Compare
Elegant and unique motion! |
c29e0be
to
37a9a5d
Compare
Could you bump package.json version to next patch (3.6.2) with this change? |
+1 on the animation, nice improvement. But I have an issue with the content - it implies this is a navigation, while being marked up with paragraphs. As such, the spacing between what looks like a nested accordion is inconsistent with the spacing in e.g. the side navigation. I think the content of the example should change to actual paragraph content to avoid confusion. |
+1ed, we agreed to address the example content in a separate pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Done
Fixes #4539
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots