Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vf-animation to vf-transition #4545

Merged

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 22, 2022

Done

  • Rename vf-animation to vf-transition
  • add vf-animation alias

Fixes #4543

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4545.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a commend in the code to mention that old name is deprecated.

Also it should result in minor version bump and be mentioned on "What's new page"

scss/_settings_animations.scss Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Aug 22, 2022

Probably outside of the scope of this PR, but when reviewing this I noticed that we actually don't use the prefers-reduced-motion media query in this mixin at all. We probably should, but to make sure it won't introduce some breaking changes it would be good to do it separately.

@petermakowski
Copy link
Contributor Author

@media (prefers-reduced-motion: reduce) {

As discussed, prefers-reduced-motion actually works due to the code above.

@petermakowski petermakowski marked this pull request as ready for review August 22, 2022 13:39
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermakowski petermakowski merged commit e6d7de4 into canonical:main Aug 23, 2022
@petermakowski petermakowski deleted the rename-to-vf-transition-#4543 branch August 23, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename vf-animation to vf-transition
3 participants