Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update accordion docs to not imply navigation #4549

Merged

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 23, 2022

Done

  • Update accordion docs to not imply navigation

Fixes #4547

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4549.demos.haus

@petermakowski petermakowski force-pushed the accordion-implies-navigation-#4547 branch from e947f32 to d5317ef Compare August 23, 2022 08:41
@petermakowski petermakowski changed the title accordion content implies navigation Update accordion docs to not imply navigation Aug 23, 2022
@lyubomir-popov
Copy link
Contributor

Much better, thanks. @bartaz do you think we need the indent? I think it looks much better without it:
image

@bartaz
Copy link
Contributor

bartaz commented Aug 23, 2022

Much better, thanks. @bartaz do you think we need the indent?

I agree that it looks better without it. Almost seems weird that we had such large padding there.

@petermakowski
Copy link
Contributor Author

Much better, thanks. @bartaz do you think we need the indent?

I agree that it looks better without it. Almost seems weird that we had such large padding there.

Thanks! Updated the padding value - this is ready for review @bartaz

@bartaz bartaz merged commit 89417a1 into canonical:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accordion content implies navigation
4 participants