Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add side navigation accordion variant #4550

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Aug 24, 2022

Done

  • add side navigation accordion variant

Fixes https://github.com/canonical/vanilla-squad/issues/1380

QA

  • Open demo
  • ensure the accordion works correctly on all screen sizes that we support

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Kapture 2022-08-25 at 10 56 52

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4550.demos.haus

@petermakowski petermakowski added the Feature 馃巵 New feature or request label Aug 24, 2022
@petermakowski petermakowski force-pushed the side-navigation-accordion-#1380 branch 5 times, most recently from 1e5137b to c082310 Compare August 25, 2022 09:01
@petermakowski petermakowski marked this pull request as ready for review August 25, 2022 09:01
@petermakowski petermakowski force-pushed the side-navigation-accordion-#1380 branch 2 times, most recently from d816d0c to 5c3c1b5 Compare August 25, 2022 09:13
@petermakowski petermakowski force-pushed the side-navigation-accordion-#1380 branch from 5c3c1b5 to 2510d71 Compare August 25, 2022 09:16
@petermakowski petermakowski force-pushed the side-navigation-accordion-#1380 branch from 2510d71 to 889cf8b Compare August 25, 2022 09:19
@bartaz bartaz force-pushed the side-navigation-accordion-#1380 branch from 8176d34 to a4aa977 Compare September 13, 2022 10:52
@bartaz bartaz merged commit 6743554 into canonical:main Sep 14, 2022
@bartaz
Copy link
Contributor

bartaz commented Sep 14, 2022

Thanks @petermakowski!

@petermakowski
Copy link
Contributor Author

Thanks @petermakowski!

Thank you. It's been a pleasure. 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants