-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
add side navigation accordion variant #4550
Merged
bartaz
merged 4 commits into
canonical:main
from
petermakowski:side-navigation-accordion-#1380
Sep 14, 2022
Merged
add side navigation accordion variant #4550
bartaz
merged 4 commits into
canonical:main
from
petermakowski:side-navigation-accordion-#1380
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://vanilla-framework-4550.demos.haus |
petermakowski
force-pushed
the
side-navigation-accordion-#1380
branch
5 times, most recently
from
August 25, 2022 09:01
1e5137b
to
c082310
Compare
petermakowski
force-pushed
the
side-navigation-accordion-#1380
branch
2 times, most recently
from
August 25, 2022 09:13
d816d0c
to
5c3c1b5
Compare
petermakowski
force-pushed
the
side-navigation-accordion-#1380
branch
from
August 25, 2022 09:16
5c3c1b5
to
2510d71
Compare
petermakowski
force-pushed
the
side-navigation-accordion-#1380
branch
from
August 25, 2022 09:19
2510d71
to
889cf8b
Compare
petermakowski
force-pushed
the
side-navigation-accordion-#1380
branch
from
August 25, 2022 15:22
889cf8b
to
adbe26d
Compare
bartaz
force-pushed
the
side-navigation-accordion-#1380
branch
from
September 13, 2022 10:52
8176d34
to
a4aa977
Compare
bartaz
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sep 14, 2022
bartaz
approved these changes
Sep 14, 2022
Thanks @petermakowski! |
Thank you. It's been a pleasure. 馃帀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes https://github.com/canonical/vanilla-squad/issues/1380
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots