Fix navigation: close open dropdown on click of toggle item.

[edlerd]

Signed-off-by: David Edler david.edler@canonical.com

Done

Fix navigation: An open dropdown should be closed on click of toggle item.
Dropdown would always stay open before, no matter how often you click on the toggle.

[webteam-app]

Demo starting at https://vanilla-framework-4566.demos.haus

[bartaz]

Do you need both closeAllDropdowns(toggles.filter((item) => item !== toggle)); and toggleDropdown(toggle, true);?

First line seems to close all OTHER toggles, so should be enough without "reopening" current one in second line.

Or you could always close all dropdowns, but reopen only if it wasn't open:

closeAllDropdowns(toggles);

if (!wasOpen) { toggleDropdown(toggle, true) }

[edlerd]

Currently, if click-target was not open, we close all others and open it.

The alternative you mention is to always close all and open the click-target if it was not open. That is how I had it initially committed. I understood your comment above, that this alternative is redundant. Because it closes the click-target and then opens it again.

Now I am a bit confused. Do we want to have this redundancy in close-and-immediately-reopen, or do we want to avoid it?