Update hacking to dotrun #4587
Merged
Update hacking to dotrun #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
added
Review: Code needed
Documentation 馃摑
|
Demo starting at https://vanilla-framework-4587.demos.haus |
bartaz
reviewed
Oct 14, 2022
guides/hacking.md
Outdated
| @@ -32,21 +32,21 @@ When writing SCSS, it's useful to run both commands in separate terminals so cha | |||
|
|
|||
| ### Via Docker | |||
|
|
|||
| It can also be run on other operating systems by first [installing Docker](https://docs.docker.com/engine/installation/) (Linux users may need to [add your user to the `docker` group](https://docs.docker.com/engine/installation/linux/linux-postinstall/)), and then using the `./run` script: | |||
| It can also be run on other operating systems by first [installing Docker](https://docs.docker.com/engine/installation/) (Linux users may need to [add your user to the `docker` group](https://docs.docker.com/engine/installation/linux/linux-postinstall/)) and then [installing dotrun](https://github.com/canonical/dotrun#installation): | |||
There was a problem hiding this comment.
The section above is Via dotrun and is currently practically a duplicate. Running via dotrun requires docker.
So I think they should be merged.
Also the section above mentions "dotrun snap" - it's not a snap anymore, so we should not call it that.
There was a problem hiding this comment.
Yeah good idea! I've merged them.
huwshimi
commented
Oct 17, 2022
| # Sass files and build automatically: | ||
| ./run watch | ||
| # See a full list of commands: | ||
| dotrun exec yarn run --non-interactive |
There was a problem hiding this comment.
I've suggested this as a feature of dotrun: canonical/dotrun#106.
bartaz
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes: #4576.
QA
n/a
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention: