Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix u-hide--large on table cells on medium screens. #4590

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Oct 17, 2022

Done

  • Fix u-hide--large hiding tds and ths on medium screens.

Fixes: #4589.

QA

  • Open the mobile table card
  • Inspect one of the table cells and add class="u-hide--large".
  • With your window at full size the cell should be hidden.
  • Resize your window to medium and small sizes and the cell should be visible.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Large screen:

Screen Shot 2022-10-17 at 11 23 43 am

Medium screen:

Screen Shot 2022-10-17 at 11 23 54 am

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4590.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit 28000e1 into canonical:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table headers and cells hidden at medium screens when using u-hide--large
3 participants