Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override responsive divider orientation for medium screens with col-m… #4594

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

huwshimi
Copy link
Contributor

@huwshimi huwshimi commented Oct 19, 2022

Done

Override responsive divider orientation for medium screens with col-medium- applied.

Fixes: #4438.

QA

  • Open the default divider demo
  • Check that at large screens you see vertical dividers but medium and small screens show horizontal dividers.
  • Open the responsive columns demo
  • Check that at large and medium screens you see vertical dividers but small screens show horizontal dividers.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

These screenshots have col-medium-2 applied to the columns.

Large:

Screen Shot 2022-10-19 at 12 31 17 pm

Medium:

Screen Shot 2022-10-19 at 12 31 29 pm

Small:

Screen Shot 2022-10-19 at 12 31 38 pm

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4594.demos.haus

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit d7efca4 into canonical:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p-divider__block doesn't handle responsive columns.
3 participants