Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the underline style of links on hover #4603

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Conversation

larryease
Copy link
Contributor

@larryease larryease commented Oct 24, 2022

Done

Updates the style of link hover

Fixes #4600

QA

  • Open demo
  • Hover over links and see if the updated style is as expected

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

webteam-app commented Oct 24, 2022

@bartaz
Copy link
Contributor

bartaz commented Oct 24, 2022

Thanks for your contribution @larryease, there is a small issue with it, that the text-decoration-thickness set on line 15 is overridden on hover in line 22.

For this to work as expected, your 2 lines should be added to hover styles (after line 22) instead of line 15.
This should fix the issue of the thickness not being applied.

Thanks!

scss/_base_links.scss Outdated Show resolved Hide resolved
@bartaz bartaz changed the title Update _base_links.scss. Issue #4600 Update the underline style of links on hover Oct 28, 2022
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larryease I removed unnecessary line and all looks good now.

Thank you for your contribution!

@bartaz bartaz merged commit 7b2f635 into canonical:main Oct 28, 2022
bartaz pushed a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the appearance of hover link underlines
4 participants