Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase z-index of the modal so that it overlays the navigation drawer #4619

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Dec 7, 2022

Done

Very small change to let the modal overlay the navigation drawer (z-index: 103), by increasing its z-index from 101 to 104.

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

Before:

Screenshot from 2022-12-07 10:17:55

After:

Screenshot from 2022-12-07 10:21:22

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4619.demos.haus

scss/_patterns_modal.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Dec 7, 2022

QA works fine on top of application layout:

image

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@bartaz bartaz merged commit 7ffe9b8 into canonical:main Dec 7, 2022
@lorumic lorumic deleted the increase-z-index-modal branch February 27, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants