New full-width layout for Design System website [WD-775] #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4621.demos.haus |
bartaz
changed the title
bartaz
changed the title
bartaz
force-pushed
the
WD-775-new-documentation-layout
branch
from
4374976
to
7d2ab58
Compare
bartaz
force-pushed
the
WD-775-new-documentation-layout
branch
from
4ab1335
to
6e4e4e8
Compare
4 tasks
bartaz
changed the title
bartaz
added
Review: Design needed
Review: QA needed
Review: Code needed
and removed
Don't merge
labels
ClementChaumel
approved these changes
Jan 24, 2023
ClementChaumel
added
Review: QA +1
Review: Code +1
and removed
Review: QA needed
Review: Code needed
labels
- fixes opening sidebar navigation on small screens - removes renundant background from HTML - fixes background and shadow styling
bartaz
force-pushed
the
WD-775-new-documentation-layout
branch
from
95afb5f
to
d18c997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Adds new layout components necessary to build new full-width site layout for Vanilla and Design System sites.
Fixes WD-775
This is currently considered experimental and internal feature, so no documentation is provided yet. We just want to release it and start using it on design.ubuntu.com and Vanilla later on.
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention:Screenshots