fix: remove collapsed side panel from accessibility tree #4628
Conversation
|
Demo starting at https://vanilla-framework-4628.demos.haus |
| @@ -235,7 +235,7 @@ $application-layout--side-nav-width-expanded: 15rem !default; | |||
| } | |||
|
|
|||
| .l-aside { | |||
| @include vf-transition($property: #{transform, box-shadow}, $duration: snap); | |||
| @include vf-transition($property: #{transform, box-shadow, visibility}, $duration: snap); | |||
There was a problem hiding this comment.
Is visibility a prop that can be transitioned?
There was a problem hiding this comment.
There was a problem hiding this comment.
Try the demo with visibility transition and without to see for yourself 馃槃
There was a problem hiding this comment.
There was a problem hiding this comment.
Cool! That simplifies a lot of things.
Based on the description it seems it "should" switch to visibility: hidden as soon as animated value is closer to 0 (so less than 0.5?) which would mean it disapears mid-transition. This doesn't seem to happen (which is good).
Anyway, thanks for the fix! We need to look if there are any other places that would benefit from that. I recall us implementing some workarounds for similar issues in side navigation.
petermakowski
changed the title
|
@petermakowski Could you bump version in package.json to 3.10.1? Thanks! |
bartaz
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code +1
labels
Done
Fixes: #4629
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵,Breaking Change 馃挘,Bug 馃悰,Documentation 馃摑,Maintenance 馃敤.package.jsonshould be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]