Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add !default to fontsizes map #4644

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Add !default to fontsizes map #4644

merged 1 commit into from
Feb 2, 2023

Conversation

lyubomir-popov
Copy link
Contributor

Fixes #4643

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4644.demos.haus

ClementChaumel
ClementChaumel approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍️

@ClementChaumel
Copy link
Contributor

It will need to be re-released before you can experiment with overriding it on other sites. How urgent is it?

@lyubomir-popov
Copy link
Contributor Author

It will need to be re-released before you can experiment with overriding it on other sites. How urgent is it?

Can wait until next week

@lyubomir-popov lyubomir-popov merged commit e7d197a into canonical:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClementChaumel ClementChaumel ClementChaumel approved these changes

Assignees

@ClementChaumel ClementChaumel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$font-sizes scss map not overridable
3 participants
@lyubomir-popov @webteam-app @ClementChaumel