Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use chevron icon in article pagination #4669

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

wszczawinski
Copy link
Contributor

@wszczawinski wszczawinski commented Feb 27, 2023

Done

  • change article pagination chevrons to dedicated icon

Fixes #4604

QA

  • Open demo
  • Make sure it uses chevron icons instead of text.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

  • before

1

4

- after

2

3

@webteam-app
Copy link

webteam-app commented Feb 27, 2023

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wszczawinski. Thanks for your contribution. Couple small fixes needed to merge this added in inline comments.

scss/_patterns_article-pagination.scss Outdated Show resolved Hide resolved
scss/_patterns_article-pagination.scss Outdated Show resolved Hide resolved
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Dzi臋ki @wszczawinski!

@bartaz bartaz merged commit 91e9cc9 into canonical:main Mar 1, 2023
@wszczawinski wszczawinski deleted the fix/article-pagination-chevron branch March 1, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Article pagination using french quotes instead of dedicated cheveron icon
3 participants