-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make updating the what's new page easier #4679
Make updating the what's new page easier #4679
Conversation
Demo starting at https://vanilla-framework-4679.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already looking good! The side navigation matching is a bit off but the what's new page looks good!
Here's what I mean BTW on that last one @bartaz which tag do you reckon we should show? |
We talked about it on standup, let's use the first/top one. And in YAML we just need to keep the order in place. But that's usually how it has been: whatever is updated on top, whatever is deprecated next. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it stands it looks good to me! Appears to do what we wanted it to!
webapp/app.py
Outdated
|
||
|
||
template_finder_view = TemplateFinder.as_view("template_finder") | ||
|
||
|
||
@app.route("/whats-new") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new route needed?
It seems it works fine as it is, under /docs/what-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh right! I thought it was under /whats-new instead of /docs/whats-new
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work, it will be very useful!
Done
Created a releases.yml file which contains information about all the releases and their important features
Fixes #4666
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]