Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract side navigation data to YAML file #4681

Conversation

abhigyanghosh30
Copy link
Contributor

@abhigyanghosh30 abhigyanghosh30 commented Mar 3, 2023

Done

Side navigation is now rendered from a YAML file instead

Fixes WD-2421

QA

  • Open demo
  • Check if side nav looks okay

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4681.demos.haus

templates/_layouts/docs.html Outdated Show resolved Hide resolved
templates/_layouts/docs.html Outdated Show resolved Hide resolved
webapp/app.py Outdated Show resolved Hide resolved
webapp/app.py Outdated Show resolved Hide resolved
templates/_layouts/docs.html Outdated Show resolved Hide resolved
url: /docs/patterns/lists
- title: Logo section
url: /docs/patterns/logo-section
- title: Updated information Matrix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small copy/paste issue here I guess:

Suggested change
- title: Updated information Matrix
- title: Matrix

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot, it's gonna make managing the navigation way easier!

@bartaz bartaz changed the title abstract side navigation to YAML file Extract side navigation data to YAML file Mar 7, 2023
@bartaz bartaz merged commit a72ca52 into canonical:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants