-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract side navigation data to YAML file #4681
Extract side navigation data to YAML file #4681
Conversation
Demo starting at https://vanilla-framework-4681.demos.haus |
side-navigation.yaml
Outdated
url: /docs/patterns/lists | ||
- title: Logo section | ||
url: /docs/patterns/logo-section | ||
- title: Updated information Matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small copy/paste issue here I guess:
- title: Updated information Matrix | |
- title: Matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot, it's gonna make managing the navigation way easier!
Done
Side navigation is now rendered from a YAML file instead
Fixes WD-2421
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]