Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename list dots to bullets #4683

Merged
merged 4 commits into from
Mar 6, 2023
Merged

Conversation

ClementChaumel
Copy link
Contributor

Done

Search and replace every instance of dots with bullets

Fixes [list issues/bugs if needed]

QA

  • Open demo
  • make sure there is no more mention of is-dotted
  • tests pass

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

webteam-app commented Mar 6, 2023

@bartaz
Copy link
Contributor

bartaz commented Mar 6, 2023

@ClementChaumel While we are at it, please rename this "Default" … maybe to "Basic"? It's not meant to be "default" anymore

image

@bartaz
Copy link
Contributor

bartaz commented Mar 6, 2023

@ClementChaumel also, as per dicsuccion in Mattermost - could do document the bullet version first, as default, and move the one without bullets later (Call it "Divided without bullets" or something…)

@bartaz bartaz merged commit 5fec7b9 into canonical:main Mar 6, 2023
@ClementChaumel ClementChaumel deleted the rename-dotted-list branch March 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants