Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mobile nav to match new design #4706

Conversation

pedoch
Copy link
Contributor

@pedoch pedoch commented Mar 17, 2023

Done

  • Update the style of the navigation on smaller screens to match the new designs on figma.

QA

  • Open the examples page
  • Select any of the navigation variants/examples under the components column.
  • Compare with the figma designs

Issues

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4706.demos.haus

@pedoch pedoch force-pushed the WD-2615-update-the-style-of-mobile-navigation-to-match-new-design branch from 4c619d4 to 56e8627 Compare March 17, 2023 16:49
@pedoch pedoch marked this pull request as ready for review March 17, 2023 16:55
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small comments.

scss/_patterns_navigation.scss Outdated Show resolved Hide resolved
scss/_patterns_navigation.scss Show resolved Hide resolved
scss/_patterns_navigation.scss Show resolved Hide resolved
@pedoch
Copy link
Contributor Author

pedoch commented Mar 20, 2023

@bartaz should be good to go now.

@bartaz
Copy link
Contributor

bartaz commented Mar 20, 2023

To fix the bundle size test just increase it, I guess make it 350000 to have some buffer:

threshold: 320000,

@bartaz bartaz changed the title WD-2615 update mobile nav to match new design Update mobile nav to match new design Mar 20, 2023
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants