Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unified spacing utils #4717

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Add unified spacing utils #4717

merged 1 commit into from
Mar 31, 2023

Conversation

yurii-vasyliev
Copy link
Contributor

@yurii-vasyliev yurii-vasyliev commented Mar 29, 2023

Done

  • Added common spacing classes to be used between elements.

Fixes WD-2884

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4717.demos.haus

scss/_settings_spacing.scss Outdated Show resolved Hide resolved
@bartaz bartaz added the Feature 馃巵 New feature or request label Mar 29, 2023
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Mostly some cosmetic comments.

templates/docs/utilities/vertical-spacing.md Show resolved Hide resolved
templates/docs/utilities/vertical-spacing.md Outdated Show resolved Hide resolved
templates/docs/utilities/vertical-spacing.md Outdated Show resolved Hide resolved
scss/_utilities_vertical-spacing.scss Outdated Show resolved Hide resolved
scss/_utilities_vertical-spacing.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Contributor

bartaz commented Mar 29, 2023

Could you also add an entry in releases.yaml file: https://github.com/canonical/vanilla-framework/blob/main/releases.yml ?

It should reference the part that changed: "Vertical spacing", "New" - because we add new class names, and link to the updated docs page.

@bartaz bartaz changed the title WD-2884: Add unified spacing utils Add unified spacing utils Mar 31, 2023
@bartaz bartaz merged commit d40b5d1 into main Mar 31, 2023
@bartaz bartaz removed the Feature 馃巵 New feature or request label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants