-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deep strip paddings #4720
Conversation
Demo starting at https://vanilla-framework-4720.demos.haus |
@lyubomir-popov Could you give this one a quick look as design review? Percy diff: https://percy.io/bb49709b/vanilla-framework/builds/26371576/changed/1467999309 I guess the change is small enough we can just release it now, without waiting for 4.0? |
@yurii-vasyliev As Lyubo mentioned on standup, could try to apply this change locally on ubuntu.com repo and run a PR with a test, so it can be verified in the context of the website? This hopefully should just require overriding |
Hey guys, Here is the URL: https://ubuntu-com-12760.demos.haus/ I haven't found deep strips, though :) So just add Thanks! |
Found couple pages with deep strips for review: Could you have a look @lyubomir-popov |
just a note that we will need to file an issue |
ubuntu.com fixes addressed in canonical/ubuntu.com#12775 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Done
8rem
and4rem
accordinglyFixes WD-2889
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 馃巵
,Breaking Change 馃挘
,Bug 馃悰
,Documentation 馃摑
,Maintenance 馃敤
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots