Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deep strip paddings #4720

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Update deep strip paddings #4720

merged 2 commits into from
Apr 12, 2023

Conversation

yurii-vasyliev
Copy link
Contributor

@yurii-vasyliev yurii-vasyliev commented Apr 3, 2023

Done

  • Increased desktop and mobile paddings for the deep strip to 8rem and 4rem accordingly

Fixes WD-2889

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4720.demos.haus

@bartaz
Copy link
Contributor

bartaz commented Apr 3, 2023

@lyubomir-popov Could you give this one a quick look as design review?

Percy diff: https://percy.io/bb49709b/vanilla-framework/builds/26371576/changed/1467999309

I guess the change is small enough we can just release it now, without waiting for 4.0?

@bartaz
Copy link
Contributor

bartaz commented Apr 5, 2023

@yurii-vasyliev As Lyubo mentioned on standup, could try to apply this change locally on ubuntu.com repo and run a PR with a test, so it can be verified in the context of the website?

This hopefully should just require overriding $spv--strip-deep: $sp-unit * 16 somewhere in ubuntu.com scss. Like here maybe? https://github.com/canonical/ubuntu.com/blob/main/static/sass/_global-settings.scss

@yurii-vasyliev
Copy link
Contributor Author

@yurii-vasyliev As Lyubo mentioned on standup, could try to apply this change locally on ubuntu.com repo and run a PR with a test, so it can be verified in the context of the website?

@bartaz @lyubomir-popov

Hey guys,

Here is the URL: https://ubuntu-com-12760.demos.haus/

I haven't found deep strips, though :) So just add is-deep to any strip for preview.

Thanks!

@lyubomir-popov
Copy link
Contributor

I think we can improve the following on the u.c repo:

remove the double space at the bottom of the last one (take out one of the is-deep classes) here: image

switch to regular strips here:
image

@lyubomir-popov
Copy link
Contributor

just a note that we will need to file an issue
and resolve those on the u/.c side

@bartaz
Copy link
Contributor

bartaz commented Apr 12, 2023

ubuntu.com fixes addressed in canonical/ubuntu.com#12775

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz added Feature 馃巵 New feature or request and removed Maintenance 馃敤 labels Apr 12, 2023
@bartaz bartaz merged commit c4819c4 into main Apr 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants