Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split list items overflowing in the other column #4722

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ClementChaumel
Copy link
Contributor

@ClementChaumel ClementChaumel commented Apr 3, 2023

Done

Fix long split list items overflowing in the second column.
Added an example of long list item to catch the regression

Fixes #4719

QA

  • Open demo
  • check that it displays correctly

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

webteam-app commented Apr 3, 2023

@bartaz bartaz merged commit 0f8049e into canonical:main Apr 4, 2023
4 checks passed
@ClementChaumel ClementChaumel deleted the fix-split-lists branch April 4, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lists with is-split wrap text between columns
3 participants