Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common grid patterns #4727

Merged
merged 11 commits into from
Apr 18, 2023
Merged

Add common grid patterns #4727

merged 11 commits into from
Apr 18, 2023

Conversation

andesol
Copy link
Contributor

@andesol andesol commented Apr 3, 2023

Done

  • Add three new classes that could work as alias for common grid patterns (.row--50-50, .row--25-75, .row--25-25-50)

Fixes WD-2886

QA

  • Open the example
  • Resize the screen and check it behaves according to the docs

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4727.demos.haus

@andesol andesol changed the title WIP: common grid patterns WIP: common grid patterns (WD-2886) Apr 3, 2023
@andesol andesol force-pushed the new-grid branch 2 times, most recently from 65bab64 to 7b606f3 Compare April 3, 2023 15:25
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but it's highly likely that we are going to want to link directly to a layout pattern. For example, in a review the designer might say we should use the 25-25-50 pattern here with a link. So individual examples and headed docs would be useful.

package.json Outdated Show resolved Hide resolved
@andesol andesol changed the title WIP: common grid patterns (WD-2886) Common grid patterns (WD-2886) Apr 5, 2023
@andesol
Copy link
Contributor Author

andesol commented Apr 6, 2023

@bartaz Ready!

@bartaz bartaz changed the title Common grid patterns (WD-2886) Common grid patterns Apr 18, 2023
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bartaz bartaz merged commit 74c54bc into main Apr 18, 2023
5 checks passed
@bartaz bartaz deleted the new-grid branch April 18, 2023 14:49
@bartaz bartaz changed the title Common grid patterns Add common grid patterns Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants